Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Print #561

Closed
SamKry opened this issue Jul 17, 2024 · 7 comments
Closed

Unnecessary Print #561

SamKry opened this issue Jul 17, 2024 · 7 comments
Assignees
Labels
Milestone

Comments

@SamKry
Copy link

SamKry commented Jul 17, 2024

Description
Since v3.5.0 there is a System.out which is called on every search next request. Is this really necessary or a leftover from testing new code?

Steps to Reproduce
Specific steps to reproduce the behavior:

  1. Open a find dialog and search for sth.

Expected behavior
No Print.

Actual behavior
Print

Screenshots
image

Remove this line.

@SamKry SamKry added the bug label Jul 17, 2024
@SamKry
Copy link
Author

SamKry commented Jul 17, 2024

I just saw that you already deleted the SysOut in the SmartHighlightPainter. Can you please release a new Version with the Fix? Thx

@SamKry SamKry closed this as completed Jul 17, 2024
@bobbylight bobbylight self-assigned this Jul 22, 2024
@bobbylight bobbylight added this to the 3.5.1 milestone Jul 22, 2024
@remcopoelstra
Copy link

I think something may have gone wrong, I just updated to 3.5.1 and noticed the sysout messages, looking at the commit history I see it was indeed removed but also added back.

The ligatures support is looking very nice by the way!

@eybisi
Copy link

eybisi commented Aug 7, 2024

#bfc9cc9 adds back sysout messages. Is this intended ? @bobbylight

@SamKry SamKry reopened this Aug 7, 2024
@hshafie
Copy link

hshafie commented Aug 14, 2024

May be not related but close.
Upgraded to 3.5.1 and when I select some text, I get:
... SmartHighlightPainter: rendering: 3662 - 3667
printed on the console, over and over, until I deselect the text.

@bobbylight
Copy link
Owner

argh, not sure how this happened! I'll fix this in a quick 3.5.2. Thanks folks

@bobbylight bobbylight modified the milestones: 3.5.1, 3.5.2 Aug 15, 2024
@bobbylight
Copy link
Owner

Fixed (for real this time, hopefully) via #566 which will be in 3.5.2.

@SamKry
Copy link
Author

SamKry commented Sep 4, 2024

Hey
When do you plan to release the new version with the fix?
Would really appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants