-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ICU4X to 1.5 and cleanup Intl #3868
Conversation
Test262 conformance changes
Fixed tests (17):
Broken tests (26):
|
Using the git repo makes sense to me. And may end up being a nice to work with for development purposes for the next little bit with all the changes coming down the pipeline to the proposal and the library (thinking the parser, duration rounding, the proposal changes). We may want to just make sure to run a release for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Check the comment if makes sense :)
Managed to fix all the Intl regressions. The remaining regressions are caused by new test changes for RegExp with CLDR 15.1 cc @raskad |
I will look into updating regress with 15.1 :) |
Some additional cleanups were made to the
Intl
services, since the ECMA-402 spec had editorial changes that hadn't been implemented.Had to pin
temporal_rs
to the git repo until we publish a new version, but it would be better to fix the panics before doing so.Removed some hacks that we had in place for locale resolution. We still have a small hack for
Segmenter
, but that will possibly be resolved in the future with locale-aware segmenters.