Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler no longer works with measureme 9.0.0 #839

Closed
neeldug opened this issue Oct 10, 2020 · 5 comments · Fixed by #840
Closed

Profiler no longer works with measureme 9.0.0 #839

neeldug opened this issue Oct 10, 2020 · 5 comments · Fixed by #840
Labels
bug Something isn't working E-Easy Easy Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com

Comments

@neeldug
Copy link
Contributor

neeldug commented Oct 10, 2020

Describe the bug
The profiler no longer functions as there was a breaking change in measureme from 0.8.0 to 9.0.0

To Reproduce

cargo run --features Boa/profiler <some.js>

Expected behavior
The profiler to produce a profile
@neeldug neeldug added the bug Something isn't working label Oct 10, 2020
@neeldug neeldug mentioned this issue Oct 10, 2020
Merged
@jasonwilliams
Copy link
Member

Thanks for raising this @neeldug i thought it was just me going mad, are our dependencies not locked? How did we update to their latest?

@jasonwilliams jasonwilliams added E-Easy Easy Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com labels Oct 10, 2020
@neeldug
Copy link
Contributor Author

neeldug commented Oct 10, 2020

@jasonwilliams I think it might’ve been merged with dependabot, since profiler isn’t tested in our current test suite, perhaps we should create one?

@jasonwilliams
Copy link
Member

jasonwilliams commented Oct 10, 2020 •
edited
Loading

@wesleywiser how big of a migration is this? is there a migration guide?

@neeldug do you have any errors or screenshots?

@wesleywiser
Copy link

wesleywiser commented Oct 10, 2020 •
edited
Loading

@jasonwilliams It should be pretty easy. Here's the PR I opened to upgrade rustc: rust-lang/rust#77398

@neeldug
Copy link
Contributor Author

neeldug commented Oct 10, 2020

@jasonwilliams here's a screenshot of the original errors: img, currently it's working but not associating the SerializationSink struct as it's no longer accepted.

Lan2u pushed a commit that referenced this issue Oct 11, 2020
@neeldug
fix(profiler): update profiler to match current measureme api (#840)
8aef556 
moves all OS profiling to use SerializationSink as the previous types
have been deprecated

Closes #839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working E-Easy Easy Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(profiler): update profiler to match current measureme api
3 participants
@wesleywiser @jasonwilliams @neeldug