📌 created files dev_requirements to pin CI Dependencies #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
reviewed
Sep 25, 2023
tox.ini
Outdated
| @@ -98,7 +89,7 @@ commands = | |||
| [testenv:bo4e-from-pip] | |||
| basepython = python3.10 | |||
| skip_install = true | |||
| deps = -r requirements/tests.txt | |||
| deps = -r requirements/tests.txt #todo: depracted? | |||
There was a problem hiding this comment.
Suggested change
| deps = -r requirements/tests.txt #todo: depracted? | |
| deps = -r requirements/requirements-tests.txt #todo: depracted? |
Comment on lines
102
to
103
| setuptools | ||
| setuptools-scm |
There was a problem hiding this comment.
warum sind setuptools nicht teil der requirements-packaging?
There was a problem hiding this comment.
pip-compile returns
#The following packages are considered to be unsafe in a requirements file:
# setuptools
(cf. jazzband/pip-tools#522 )
There was a problem hiding this comment.
ok, kommt dann mit dem umstieg auf hatchling eh weg.
Co-authored-by: konstantin <konstantin.klein@hochfrequenz.de>
hf-kklein
reviewed
Sep 25, 2023
tox.ini
Outdated
| commands = python -m pytest --basetemp={envtmpdir} {posargs} | ||
|
|
||
|
|
||
| [testenv:linting] | ||
| deps = | ||
| -rrequirements.txt | ||
| #-r requirements.txt |
There was a problem hiding this comment.
wieso braucht es die requiements nicht mehr fürs linting?
There was a problem hiding this comment.
Sorry, übersehen. 4ead9eb
hf-kklein
approved these changes
Sep 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.