Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make function comments match function names #208

Closed
wants to merge 1 commit into from

Conversation

piguagua
Copy link

Description

make function comments match function names

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Signed-off-by: piguagua <piguagua@aliyun.com>
@github-actions github-actions bot requested review from bnoieh and welkin22 June 10, 2024 09:37
@piguagua
Copy link
Author

piguagua commented Aug 4, 2024

friendly ping~

@welkin22
Copy link
Contributor

welkin22 commented Aug 15, 2024

@piguagua hi, thank you for your submission. Although there are no issues with these comments changes, since the errors in these comments originate from our upstream, we prefer to wait for the upstream to fix them and then merge the changes through the upstream. This will reduce the burden of merging upstream code conflicts for us. Therefore, I will not merge this PR. We appreciate your continued focus on our code quality and encourage you to submit additional content to aid in our enhancement efforts.

@welkin22 welkin22 closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants