fix(ci): fix e2e test failures after merge #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
reviewed
Feb 27, 2024
|
The ci is not triggered in this PR. Can we enable it to check the effect before it's merged (by add adding trigger condition of this branch or manually trigger)? |
I tested in my repository and currently encountered some problems that are still being solved. |
bnoieh
approved these changes
Mar 8, 2024
owen-reorg
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging upstream 1.3.0, there were significant changes in the e2e test, and some cases failed to pass the test and need to be fixed.
Rationale
fix e2e test case
Example
none
Changes
Notable changes: