-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(op-node/op-batcher/op-proposer): the fallback client should always try recover #118
Merged
owen-reorg
merged 11 commits into
bnb-chain:develop
from
welkin22:bugfix/fallback_recover
Mar 7, 2024
Merged
fix(op-node/op-batcher/op-proposer): the fallback client should always try recover #118
owen-reorg
merged 11 commits into
bnb-chain:develop
from
welkin22:bugfix/fallback_recover
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
previously approved these changes
Jan 30, 2024
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
andyzhang2023
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
owen-reorg
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In extreme cases, all of our endpoint URLs may be unable to connect, and the
rpcInitFunc
will return an error, causing therecoverIfFirstRpcHealth
function to not have a chance to execute. So when the endpoint URLs are restored, our currentIndex counter still points to the end of the urlList array, causing internal state confusion in the fallbackClient and permanently disabling the fallback function until the node is restarted.Rationale
We use
defer
to ensure that no matter what the situation,recoverIfFirstRpcHealth
will be executed.Example
none
Changes
Notable changes:
defer
to ensure thatrecoverIfFirstRpcHealth
will always be executed regardless of the circumstances.lastRpc.Close()
, which will cause confusion in subsequent logic execution.