fix(op-node): pre-fetching handle L1 reOrg round 2 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoieh
reviewed
Jan 30, 2024
bnoieh
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #115, I added the ability to handle L1 reorganization to pre-fetching. During testing, I found that if the cache already exists, blockInfo should also be added to blockInfoChan, which avoids oldestBlockParentHash and parentHash being incorrectly set to common.hash.
Rationale
Even if the cache already exists, blockInfo should be stuffed into blockInfoChan to avoid incorrect recording of the parent hash.
In addition, due to the higher reliability requirements for pre-fetching, PreFetchReceipts will continue to loop until successful after returning err.
Example
none
Changes
Notable changes: