receipt cache limited by volumes #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendanzhentan
force-pushed
the
cache-max-volumn
branch
2 times, most recently
from
630cc4c to
a5d2767
Compare
bendanzhentan
force-pushed
the
cache-max-volumn
branch
from
a5d2767 to
40dd44d
Compare
welkin22
reviewed
Dec 25, 2023
op-node/sources/caching/blob_lru.go
Outdated
| type SizeConstrainedCache[K comparable, V any] struct { | ||
| m Metrics | ||
| label string | ||
| size int |
There was a problem hiding this comment.
Perhaps uint64 type should be used instead, it is uncertain if int type will overflow when counting byte size.
op-node/sources/eth_client.go
Outdated
| } else { | ||
| txHashes := eth.TransactionsToHashes(txs) | ||
| job = NewReceiptsFetchingJob(s, s.client, s.maxBatchSize, eth.ToBlockID(info), info.ReceiptHash(), txHashes) | ||
| _, err := job.Fetch(ctx) |
There was a problem hiding this comment.
There is no need to execute Fetch here, please refer to the comments above. The reason for caching the job instead of the receipts is that it saves the intermediate state, so even if it fails, it can continue to execute the next time.
bendanzhentan
force-pushed
the
cache-max-volumn
branch
2 times, most recently
from
49a8c69 to
352ccb6
Compare
bendanzhentan
force-pushed
the
cache-max-volumn
branch
from
352ccb6 to
329f0c3
Compare
bendanzhentan
force-pushed
the
cache-max-volumn
branch
from
329f0c3 to
fe8cf5a
Compare
bendanzhentan
changed the title
|
Two concerns:
I'm not sure if it's worth it. |
|
Using higher memory should be good enough for now, we'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receipts cache was originally a LRUCache type that was limited by the number of elements, but there is a problem, meaning that if the recent block contains too many receipts, then the receipts cache can take up a lot of memory. To limit the memory usage of the receipts cache, this PR changes the cache type to SizeConstrainedCache, which is limited by the total volume of elements.