Txpool opt async priced #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 26, 2024 15:51
add async priced list
…ed to check Underpriced() when floating or urgent list is empty
owen-reorg
reviewed
Jan 2, 2025
owen-reorg
reviewed
Jan 2, 2025
owen-reorg
reviewed
Jan 2, 2025
bnoieh
reviewed
Jan 7, 2025
|
I see no log for the new feature, better add proper debug/info logs |
Added. |
owen-reorg
approved these changes
Jan 8, 2025
bnoieh
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An "async-reheap" priced list is introduced into txpool to get better performance. The re-heap of the whole transaction pool usually costs hundreds of ms, which blocks more transactions coming into the pool through the Add() function. So we develop a new type of priced list to resolve the bottleneck.
The "async-reheap" finds the "lowest-priced" transactions async, and stores it into a cache, then it does the "underpriced" validation quickly by the stored cache.
Example
add flag
--txpool.asyncpricedto enable this feature.