[WIP]: Add a upgrade to support new validator power rank key #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are too many imcompatible changes recently, do we need to add this upgrade in testnet |
|
To reduce the risk of upgrading testnet, I think it is better to not include this upgrade to testnet. However, if this change has not been verified by testnet, is it too risky to directly include it to mainnet? |
we have qa environment |
|
OK. That's fine. Let's deley postpone this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade cosmos dependency to support new method to build validator power rank key
Rationale
Please refer to cosmos/cosmos-sdk#2909. There is a bug in current method to build validator power rank key.
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related PR
bnb-chain/bnc-cosmos-sdk#100