feat: add index by id for storage module #80
Conversation
fynnss
force-pushed
the
support_index_by_id
branch
from
7c451df to
6701c0e
Compare
fynnss
force-pushed
the
support_index_by_id
branch
from
6701c0e to
faa3a90
Compare
x/sp/keeper/sp.go
Outdated
| @@ -6,6 +6,21 @@ import ( | |||
| "github.com/bnb-chain/greenfield/x/sp/types" | |||
| ) | |||
|
|
|||
| func (k Keeper) CheckIfValidStorageProvider(ctx sdk.Context, addr sdk.AccAddress) error { | |||
There was a problem hiding this comment.
should CheckIsValidStorageProvider better
There was a problem hiding this comment.
how about IsStorageProviderExistAndInService?
| }); err != nil { | ||
| return nil, err | ||
| } | ||
| _ = id |
There was a problem hiding this comment.
@alexgao001 will impl this.
fynnss
force-pushed
the
support_index_by_id
branch
from
766c0e7 to
c31eea0
Compare
fynnss
force-pushed
the
support_index_by_id
branch
from
c31eea0 to
995c635
Compare
fynnss
force-pushed
the
support_index_by_id
branch
from
e1d36ce to
b3614af
Compare
| } | ||
|
|
||
| sp := types.MustUnmarshalStorageProvider(k.cdc, value) | ||
| if sp.Status != types.STATUS_IN_SERVICE { |
There was a problem hiding this comment.
CheckIfValidStorageProvider seems the validator must be in service, any way to reflect this in the name of this function to make it more readable?
There was a problem hiding this comment.
how about IsStorageProviderExistAndInService?
|
I did not dive into the details of this PR, will do a thorough review of the refactor PR. Please fix the e2e case. LGTM |
Thinks. E2e test case has been fixed. Please help review again. |
fynnss
force-pushed
the
support_index_by_id
branch
from
537612f to
ec16a00
Compare
Description
add index bucket/object/group by id for storage module
Changes
Notable changes: