feat: implement paymaster #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
| @@ -110,3 +110,12 @@ message LocalVirtualGroup { | |||
| // Notice that the minimum unit of charge is 128K | |||
| uint64 total_charge_size = 4; | |||
| } | |||
|
|
|||
| message BucketFlowRateLimit { | |||
There was a problem hiding this comment.
BucketFlowRateLimit is just Int. Why we need this instead of using Int?
There was a problem hiding this comment.
we can add another fields
alexgao001
reviewed
Mar 7, 2024
unclezoro
reviewed
Mar 8, 2024
unclezoro
reviewed
Mar 8, 2024
unclezoro
reviewed
Mar 8, 2024
| k.deleteBucketFlowRateLimitForDifferentBucketOwner(ctx, paymentAccount, bucketOwner, bucketName) | ||
|
|
||
| // set the flow rate limit for the bucket for the current bucket owner | ||
| err := k.setFlowRateLimit(ctx, bucket, paymentAccount, bucketName, rateLimit) |
There was a problem hiding this comment.
setFlowRateLimit the function name seem not good, it is simliar to setBucketFlowRateLimit, but it does a lot of things.
unclezoro
reviewed
Mar 8, 2024
| } | ||
|
|
||
| internalBucketInfo := k.MustGetInternalBucketInfo(ctx, bucketInfo.Id) | ||
| isRateLimited := k.isBucketRateLimited(ctx, bucketName) |
There was a problem hiding this comment.
it is very hard to understand isRateLimited from the word.. any better wording?
unclezoro
reviewed
Mar 8, 2024
unclezoro
reviewed
Mar 8, 2024
unclezoro
reviewed
Mar 8, 2024
unclezoro
reviewed
Mar 8, 2024
| if currentFlows != nil { | ||
| flowList = append(flowList, *currentFlows) | ||
| } | ||
|
|
There was a problem hiding this comment.
what is the motivation to change the code here?
There was a problem hiding this comment.
because the previous code don't allow empty currentFlows and previousFlows, but when we resume the bucket, the previousFlows is empty
forcodedancing
approved these changes
Mar 14, 2024
alexgao001
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will implements BEP bnb-chain/BEPs#362.
Rationale
Implement paymaster.
Example
n/a
Changes
Notable changes:
MsgSetBucketFlowRateLimitPotential Impacts
CreatObject,CreateBucketand etc.