feat: Add deploy scripts for sp #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingjunLi
force-pushed
the
add_deploy_scripts_for_sp
branch
from
461075e
to
afeb60c
Compare
fynnss
reviewed
Feb 15, 2023
deployment/localup/localup.sh
Outdated
|
|
||
| n=0 | ||
| while [ $n -le 360 ]; do | ||
| approval_cnt=("$(${bin} query sp storage-providers --node http://localhost:26750 | grep approval_address | wc -l)") |
There was a problem hiding this comment.
I fix it to cnt, means the sp cnt added to chain.
fynnss
reviewed
Feb 15, 2023
deployment/localup/localup.sh
Outdated
| @@ -7,6 +7,10 @@ source ${workspace}/utils.sh | |||
| bin_name=gnfd | |||
| bin=${workspace}/../../build/bin/${bin_name} | |||
|
|
|||
| function build() { | |||
fynnss
reviewed
Feb 15, 2023
deployment/localup/localup.sh
Outdated
| @@ -150,11 +154,124 @@ function stop() { | |||
| ps -ef | grep ${bin_name} | grep validator | awk '{print $2}' | xargs kill | |||
| } | |||
|
|
|||
| function validator_deploy() { | |||
There was a problem hiding this comment.
It's a little bit confusing about this function name. why need sp_size when deploy validator?
There was a problem hiding this comment.
fixed, add sp_join & sp_check, these two functions only use sp_size。
fynnss
reviewed
Feb 15, 2023
jingjunLi
force-pushed
the
add_deploy_scripts_for_sp
branch
from
e7be29d
to
dc3b4b1
Compare
jingjunLi
requested review from
yutianwu,
owen-reorg,
flywukong and
joeylichang
unclezoro
requested changes
Feb 16, 2023
unclezoro
approved these changes
Feb 16, 2023
fynnss
approved these changes
Feb 16, 2023
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add deploy storage provider function for localup.sh
Example
./deployment/localup/localup.sh all 1 3
start validator & add 3 sps join the chain.
after about 4-5 mins, use
./deployment/localup/localup.sh sp_check 3check whether sp added success.