fix: policy key is not GC while a expired policy is GC #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
approved these changes
Oct 27, 2023
alexgao001
force-pushed
the
fix-delete-policy-key
branch
from
20b4573
to
82c06b6
Compare
alexgao001
force-pushed
the
fix-delete-policy-key
branch
2 times, most recently
from
78a87c9
to
151dfa5
Compare
alexgao001
force-pushed
the
fix-delete-policy-key
branch
from
151dfa5
to
b984d4c
Compare
pythonberg1997
approved these changes
Oct 27, 2023
unclezoro
approved these changes
Oct 30, 2023
This was referenced Nov 2, 2023
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a account policy is expired, it should be automatically removed from the store with these two mappings:
currently
policyKey -> policyIdis missing so that user would fail to re-put policy on the same resource.When a group policy expired, also need to remove it from the policyGroup.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: