Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse failed when object name contains / #369

Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix: parse failed when object name contains / #369

merged 2 commits into from
Jul 25, 2023

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Jul 25, 2023 •
edited
Loading

Description

fix parse bucket and object name failed when object name contains "/"

Rationale

bufix

Example

grn:o::testbucket/test/test2/object

Changes

Notable changes:

  • grn ParseBucketAndObjectName
  • grn test

aiden-cao
aiden-cao approved these changes Jul 25, 2023
View reviewed changes
Copy link

@aiden-cao aiden-cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fynnss fynnss changed the base branch from master to develop July 25, 2023 06:23
@unclezoro unclezoro added this pull request to the merge queue Jul 25, 2023
Merged via the queue into develop with commit 04fa65c Jul 25, 2023
5 checks passed
This was referenced Jul 25, 2023
Merged
Merged
@fynnss fynnss deleted the fix_grn_parse_bucket_and_object_name branch July 26, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@aiden-cao aiden-cao aiden-cao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fynnss @unclezoro @aiden-cao