-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix issues and add test cases for payment #348
Merged
forcodedancing
merged 36 commits into
bnb-chain:develop
from
forcodedancing:payment_refine
Jul 21, 2023
Merged
feat: fix issues and add test cases for payment #348
forcodedancing
merged 36 commits into
bnb-chain:develop
from
forcodedancing:payment_refine
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. add update bucket quota and payment testcase
forcodedancing
force-pushed
the
payment_refine
branch
from
July 20, 2023 01:26
7f13f90
to
6c14e77
Compare
forcodedancing
force-pushed
the
payment_refine
branch
from
July 20, 2023 01:35
6c14e77
to
44d38d4
Compare
forcodedancing
commented
Jul 20, 2023
yutianwu
reviewed
Jul 21, 2023
unclezoro
reviewed
Jul 21, 2023
yutianwu
reviewed
Jul 21, 2023
yutianwu
reviewed
Jul 21, 2023
there are lint errors, pls also check |
fynnss
reviewed
Jul 21, 2023
yutianwu
approved these changes
Jul 21, 2023
fynnss
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will fix several issues in payment and related modules, it also add more test cases for payment.
Rationale
Bug fix and test enhancement
Example
NA
Changes
Notable changes: