feat: allows for setting a custom http client when NewGreenfieldClient #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irrun
force-pushed
the
feat-downloadopt
branch
2 times, most recently
from
1164205
to
fd01e35
Compare
unclezoro
reviewed
Jun 25, 2023
unclezoro
reviewed
Jun 25, 2023
sdk/client/gnfd_client.go
Outdated
| @@ -174,6 +175,38 @@ func NewGreenfieldClient(rpcAddr, chainId string, opts ...GreenfieldClientOption | |||
| return client, nil | |||
| } | |||
|
|
|||
| // NewGreenfieldClientWithClient is used to create a new GreenfieldClient structure, allows for setting a custom http client | |||
| func NewGreenfieldClientWithClient(rpcAddr, chainId string, httpclient *http.Client, opts ...GreenfieldClientOption) (*GreenfieldClient, error) { | |||
There was a problem hiding this comment.
The function name seems bad, please come up with new one.
unclezoro
reviewed
Jun 25, 2023
irrun
force-pushed
the
feat-downloadopt
branch
2 times, most recently
from
1890a51
to
8747354
Compare
unclezoro
approved these changes
Jun 25, 2023
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: allows for setting a custom http client when NewGreenfieldClient