-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add versioned parameters to payment module #281
feat: add versioned parameters to payment module #281
Conversation
Better to have e2e cases to cover the usage.
|
There are still chances that delete an object may fail after this fix. So the delete object function in Endblock has to handle this scenario. |
Added new E2E testcases into payment e2e test. |
15ac3df
to
6c698f4
Compare
As discussed, this should be ok. Added new testcase to cover this. |
d3fafd0
to
0a372da
Compare
ff12405
to
47faece
Compare
Description
This pr will add versioned parameter to payment module.
Currently,
ReserveTime
is a multiple version parameter.Rationale
When
unlock
creation fee, we need to know the exact amount locked.Example
NA
Changes
Notable changes: