fix: check every module's Msg #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sdk.Msg implement for missing msg
yutianwu
approved these changes
Jun 1, 2023
fynnss
reviewed
Jun 1, 2023
x/sp/types/codec.go
Outdated
| @@ -14,6 +14,7 @@ func RegisterCodec(cdc *codec.LegacyAmino) { | |||
| cdc.RegisterConcrete(&MsgEditStorageProvider{}, "sp/EditStorageProvider", nil) | |||
| cdc.RegisterConcrete(&MsgUpdateSpStoragePrice{}, "sp/UpdateSpStoragePrice", nil) | |||
| cdc.RegisterConcrete(&DepositAuthorization{}, "sp/DepositAuthorization", nil) | |||
| cdc.RegisterConcrete(&MsgUpdateParams{}, "sp/MsgUpdateParams", nil) | |||
There was a problem hiding this comment.
Why is only this one with the Msg prefix? And isn't Amino already deprecated?
There was a problem hiding this comment.
Can we just remove this func func RegisterCodec(cdc *codec.LegacyAmino) ?
There was a problem hiding this comment.
It's a mistake. I add it when tested, it will be deleted.
There was a problem hiding this comment.
func RegisterCodec(cdc *codec.LegacyAmino) can not remove, it was used in
(AppModuleBasic) RegisterLegacyAminoCodec, which is used by greendfield-cosmos-sdk.
forcodedancing
approved these changes
Jun 2, 2023
fynnss
approved these changes
Jun 3, 2023
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check every module‘s Msg implementation:
RegisterInterfacesmethodRegisterCodecis obsolete and has not been processed yetsdk.MsgRationale
they were used by GreenfieldScan.
Example
NA
Changes
Notable changes: