feat: remove ValAddress and update EIP712 related functions #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
force-pushed
the
metamask
branch
from
23ea1f8
to
b5dbd6f
Compare
unclezoro
approved these changes
Jan 16, 2023
This was referenced Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adopt a new solution for EIP712 sign mode. Previously, we use amino codec to marshal the msg in txn and there're a lot of problems. Now we adopt proto codec. Besides that, all *Any types in msg will be treated as bytes rather than unpack it.
Rationale
N/A
Example
N/A
Changes
Notable changes: