feat: support multiple messages in single tx for EIP712 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynnss
approved these changes
May 17, 2023
| msgCreateBucket.PrimarySpApproval.Sig, err = sp.ApprovalKey.Sign(msgCreateBucket.GetApprovalBytes()) | ||
| s.Require().NoError(err) | ||
|
|
||
| // UpdateBucketInfo |
There was a problem hiding this comment.
@flywukong We can use this feature to add an CreateBucketIfNotExist option to CreateObjectOptions which means create the bucket if it does not exist. This will bring better user exprience.
forcodedancing
force-pushed
the
feat/eip712
branch
from
bf88602
to
71a7637
Compare
unclezoro
approved these changes
May 19, 2023
|
The e2e seems failed, please fix. |
Some issues introduced in rebase. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will support multiple messages in a transaction using EIP712 sign approach.
Rationale
By allowing multiple messages, it will provide better user experience for dApp users.
Example
NA
Changes
Notable changes: