-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multi version params for storage module #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingjunLi
force-pushed
the
chris/multi-version-params
branch
from
April 26, 2023 06:35
b206b8f
to
eaef5f9
Compare
fynnss
reviewed
Apr 26, 2023
jingjunLi
force-pushed
the
chris/multi-version-params
branch
2 times, most recently
from
May 5, 2023 08:10
ec2cf03
to
f59c18a
Compare
owen-reorg
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jingjunLi
force-pushed
the
chris/multi-version-params
branch
from
May 6, 2023 02:51
90e7348
to
2e120e2
Compare
fynnss
approved these changes
May 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support multi-version params for storage module
Rationale
Some configuration parameters may change, such as
MinChargeSize
. To find the parameters corresponding to the creation time according to the time when the object was created.Example
NA
Changes
Notable changes:
make format