Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multi version params for storage module #218

Merged
merged 9 commits into from
May 6, 2023

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Apr 26, 2023

Description

support multi-version params for storage module

Rationale

Some configuration parameters may change, such as MinChargeSize. To find the parameters corresponding to the creation time according to the time when the object was created.

Example

NA

Changes

Notable changes:

  • format some code make format
  • ...

@jingjunLi jingjunLi added the wip label Apr 26, 2023
@jingjunLi jingjunLi force-pushed the chris/multi-version-params branch from b206b8f to eaef5f9 Compare April 26, 2023 06:35
proto/greenfield/storage/params.proto Outdated Show resolved Hide resolved
x/storage/keeper/params.go Outdated Show resolved Hide resolved
x/storage/keeper/params.go Outdated Show resolved Hide resolved
x/storage/types/keys.go Show resolved Hide resolved
proto/greenfield/storage/params.proto Outdated Show resolved Hide resolved
@jingjunLi jingjunLi force-pushed the chris/multi-version-params branch 2 times, most recently from ec2cf03 to f59c18a Compare May 5, 2023 08:10
@jingjunLi jingjunLi added r4r and removed wip labels May 5, 2023
@jingjunLi jingjunLi requested a review from RenRick May 5, 2023 08:18
Copy link
Contributor

@owen-reorg owen-reorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingjunLi jingjunLi force-pushed the chris/multi-version-params branch from 90e7348 to 2e120e2 Compare May 6, 2023 02:51
Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fynnss fynnss merged commit c119c32 into develop_v0.47_latest May 6, 2023
@unclezoro unclezoro deleted the chris/multi-version-params branch August 16, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants