feat: migrate challenge module to cosmos sdk v0.47

app/app.go

@@ -494,14 +494,13 @@ func New(
 	app.ChallengeKeeper = *challengemodulekeeper.NewKeeper(
 		appCodec,
 		keys[challengemoduletypes.StoreKey],
-		memKeys[challengemoduletypes.MemStoreKey],
 		tKeys[challengemoduletypes.TStoreKey],
-		app.GetSubspace(challengemoduletypes.ModuleName),
 		app.BankKeeper,
 		app.StorageKeeper,
 		app.SpKeeper,
 		app.StakingKeeper,
 		app.PaymentKeeper,
+		authtypes.NewModuleAddress(challengemoduletypes.ModuleName).String(),
 	)
 	challengeModule := challengemodule.NewAppModule(appCodec, app.ChallengeKeeper, app.AccountKeeper, app.BankKeeper)
 

proto/greenfield/challenge/tx.proto

@@ -4,6 +4,7 @@ package greenfield.challenge;
 import "cosmos/msg/v1/msg.proto";
 import "cosmos_proto/cosmos.proto";
 import "gogoproto/gogo.proto";
+import "greenfield/challenge/params.proto";
 import "greenfield/challenge/types.proto";
 
 // this line is used by starport scaffolding # proto/tx/import
@@ -14,6 +15,12 @@ option go_package = "github.com/bnb-chain/greenfield/x/challenge/types";
 service Msg {
   rpc Submit(MsgSubmit) returns (MsgSubmitResponse);
   rpc Attest(MsgAttest) returns (MsgAttestResponse);
+
+  // UpdateParams defines a governance operation for updating the x/challenge module parameters.
+  // The authority is defined in the keeper.
+  //
+  // Since: cosmos-sdk 0.47
+  rpc UpdateParams(MsgUpdateParams) returns (MsgUpdateParamsResponse);
   // this line is used by starport scaffolding # proto/tx/rpc
 }
 
@@ -79,4 +86,18 @@ message MsgAttest {
 // MsgAttest defines the response of MsgAttestResponse.
 message MsgAttestResponse {}
 
+// MsgUpdateParams is the Msg/UpdateParams request type.
+message MsgUpdateParams {
+  option (cosmos.msg.v1.signer) = "authority";
+
+  // authority is the address that controls the module (defaults to x/gov unless overwritten).
+  string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
+
+  // params defines the x/challenge parameters to update.
+  // NOTE: All parameters must be supplied.
+  Params params = 2 [(gogoproto.nullable) = false];
+}
+
+// MsgUpdateParamsResponse defines the response structure for executing a MsgUpdateParams message.
+message MsgUpdateParamsResponse {}
 // this line is used by starport scaffolding # proto/tx/message

x/challenge/abci.go

@@ -18,18 +18,20 @@ func BeginBlocker(ctx sdk.Context, keeper k.Keeper) {
 	keeper.RemoveChallengeUntil(ctx, blockHeight)
 
 	// delete too old slashes at this height
-	coolingOff := keeper.SlashCoolingOffPeriod(ctx)
-	if blockHeight <= coolingOff {
+	coolingOffPeriod := keeper.GetParams(ctx).SlashCoolingOffPeriod
+	if blockHeight <= coolingOffPeriod {
 		return
 	}
 
-	height := blockHeight - coolingOff
+	height := blockHeight - coolingOffPeriod
 	keeper.RemoveSlashUntil(ctx, height)
 }
 
 func EndBlocker(ctx sdk.Context, keeper k.Keeper) {
 	count := keeper.GetChallengeCountCurrentBlock(ctx)
-	needed := keeper.ChallengeCountPerBlock(ctx)
+
+	params := keeper.GetParams(ctx)
+	needed := params.ChallengeCountPerBlock
 	if count >= needed {
 		return
 	}
@@ -40,7 +42,7 @@ func EndBlocker(ctx sdk.Context, keeper k.Keeper) {
 	}
 
 	segmentSize := keeper.StorageKeeper.MaxSegmentSize(ctx)
-	expiredHeight := keeper.ChallengeKeepAlivePeriod(ctx) + uint64(ctx.BlockHeight())
+	expiredHeight := params.ChallengeKeepAlivePeriod + uint64(ctx.BlockHeight())
 
 	events := make([]proto.Message, 0)                      // for events
 	objectMap := make(map[string]struct{})                  // for de-duplication

x/challenge/client/cli/query.go

@@ -30,6 +30,30 @@ func GetQueryCmd(queryRoute string) *cobra.Command {
 	return cmd
 }
 
+func CmdQueryParams() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "params",
+		Short: "Shows the parameters of the module",
+		Args:  cobra.NoArgs,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			clientCtx := client.GetClientContextFromCmd(cmd)
+
+			queryClient := types.NewQueryClient(clientCtx)
+
+			res, err := queryClient.Params(cmd.Context(), &types.QueryParamsRequest{})
+			if err != nil {
+				return err
+			}
+
+			return clientCtx.PrintProto(res)
+		},
+	}
+
+	flags.AddQueryFlagsToCmd(cmd)
+
+	return cmd
+}
+
 func CmdLatestAttestedChallenges() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "latest-attested-challenges",

x/challenge/genesis.go

@@ -10,7 +10,10 @@ import (
 // InitGenesis initializes the module's state from a provided genesis state.
 func InitGenesis(ctx sdk.Context, k keeper.Keeper, genState types.GenesisState) {
 	// this line is used by starport scaffolding # genesis/module/init
-	k.SetParams(ctx, genState.Params)
+	err := k.SetParams(ctx, genState.Params)
+	if err != nil {
+		panic(err)
+	}
 }
 
 // ExportGenesis returns the module's exported genesis