Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify sp module & storage module & permission module to adapt cosmos sdk v0.47 #196

Merged
merged 18 commits into from
Apr 25, 2023
Merged

feat: modify sp module & storage module & permission module to adapt cosmos sdk v0.47 #196

merged 18 commits into from
Apr 25, 2023

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Apr 21, 2023 •
edited
Loading

Description

This pr will adapt the sp module * storage module & permission module for cosmos sdk v0.47 .

Rationale

To sync with cosmos sdk version.

Example

NA

Changes

Notable changes:

  • NA
  • ...

@jingjunLi jingjunLi added the wip label Apr 21, 2023
@jingjunLi jingjunLi force-pushed the chris/adapt-v0.47-storage-module branch from 9a0af77 to f87c9d5 Compare April 21, 2023 07:25
@jingjunLi jingjunLi changed the title feat: adapt v0.47 storage module feat: adapt cosmos sdk v0.47 sp module & storage module & permission module Apr 21, 2023
@jingjunLi jingjunLi changed the title feat: adapt cosmos sdk v0.47 sp module & storage module & permission module feat: modify sp module & storage module & permission module to adapt cosmos sdk v0.47 Apr 21, 2023
@jingjunLi jingjunLi force-pushed the chris/adapt-v0.47-storage-module branch from 29cd8db to 6c1a7f7 Compare April 21, 2023 08:28
fynnss
fynnss reviewed Apr 23, 2023
View reviewed changes
app/app.go Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@forcodedancing
Copy link
Contributor

Currently, the blockchain can be bring up locally.
Can you also run make e2e_start_localchain and the e2e tests for these modules, to make sure the e2e tests can pass?

@jingjunLi jingjunLi force-pushed the chris/adapt-v0.47-storage-module branch from 9ebda39 to d4243fe Compare April 24, 2023 08:21
@jingjunLi jingjunLi added r4r and removed wip labels Apr 25, 2023
@yutianwu yutianwu merged commit 4f77e56 into develop_v0.47_latest Apr 25, 2023
@randyahx randyahx mentioned this pull request May 11, 2023
Merged
@unclezoro unclezoro mentioned this pull request May 12, 2023
Merged
@unclezoro unclezoro deleted the chris/adapt-v0.47-storage-module branch August 16, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fynnss fynnss fynnss left review comments

@yutianwu yutianwu yutianwu approved these changes

@forcodedancing forcodedancing forcodedancing approved these changes

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jingjunLi @forcodedancing @yutianwu @fynnss