Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support empty operator for verifypermission #187

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Apr 19, 2023

Description

Support the need for anonymous users to access public resources

Rationale

  • Anonymous user address is allowed, i.e. operator address is empty
    operator, err := sdk.AccAddressFromHexUnsafe(req.Operator) if err != nil && err != sdk.ErrEmptyHexAddress
  • The permission in VerifyBucketPermission & VerifyObjectPermission when empty operator. If the resource if public, user can access it.

Changes

Notable changes:

  • VerifyBucketPermission & VerifyObjectPermission
  • ...

@fynnss
Copy link
Contributor

fynnss commented Apr 20, 2023

Pls refine the PR description

@jingjunLi
Copy link
Contributor Author

@fynnss Refine the PR description is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants