fix: add ErrInvalidApproval errorcode for sp's approval invalid
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingjunLi
changed the title
jingjunLi
changed the title
ErrInvalidApproval errorcode for sp's approval invalid
RenRick
reviewed
Apr 14, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| approvalAccAddress := sdk.MustAccAddressFromHex(sp.ApprovalAddress) | ||
|
|
There was a problem hiding this comment.
Don't need to check the "err" value returned any more?
There was a problem hiding this comment.
Here the AccAddressFromHexUnsafe function is replaced with MustAccAddressFromHex.
It is agreed on the chain that the address stored on the chain must be correct, and the MustAccAddressFromHex interface is judged. If there is an error in parsing the address, it will panic.
unclezoro
approved these changes
Apr 17, 2023
randyahx
pushed a commit
that referenced
this pull request
Apr 20, 2023
unclezoro
pushed a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user creates a bucket on sp1 and then creates an object on sp2, the error message will be more accurate. Use the ErrInvalidApproval error code to indicate an invalid approval from sp.
Changes
Notable changes: