Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unify property names #172

Merged
merged 1 commit into from
Apr 14, 2023
Merged

feat: unify property names #172

merged 1 commit into from
Apr 14, 2023

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Apr 12, 2023 •
edited
Loading

Description

unify property names in events and DOs:

  • OwnerAddress➝Owner
  • CreatorAddress➝Creator
  • OperatorAddress → Operator

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@jingjunLi
unify-property-names:
c2f1fb0 
OwnerAddress➝Owner
CreatorAddress➝Creator
OperatorAddress → Operator
@jingjunLi jingjunLi changed the title feat: unify-property-names: feat: unify property names Apr 12, 2023
@jingjunLi jingjunLi added the r4r label Apr 12, 2023
2129zxl
2129zxl approved these changes Apr 14, 2023 •
edited
Loading
View reviewed changes
krish-nr
krish-nr approved these changes Apr 14, 2023
View reviewed changes
Copy link

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fynnss
fynnss approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fynnss fynnss merged commit 6afb215 into develop Apr 14, 2023
@unclezoro unclezoro deleted the chris/unify-property-names branch April 18, 2023 09:19
@randyahx randyahx mentioned this pull request Apr 20, 2023
Merged
randyahx pushed a commit that referenced this pull request Apr 20, 2023
@jingjunLi @randyahx
fix: unify property field names of events: (#172)
02bfb20
unclezoro pushed a commit that referenced this pull request Apr 20, 2023
@jingjunLi @unclezoro
fix: unify property field names of events: (#172)
dacae45
@randyahx randyahx mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2129zxl 2129zxl 2129zxl approved these changes

@fynnss fynnss fynnss approved these changes

@krish-nr krish-nr krish-nr approved these changes

@unclezoro unclezoro Awaiting requested review from unclezoro

@RenRick RenRick Awaiting requested review from RenRick

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jingjunLi @2129zxl @fynnss @krish-nr