feat: refactor key manager to hide private key. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
reviewed
Apr 3, 2023
sdk/keys/key_manager.go
Outdated
| //TODO NewKeyStoreKeyManager to be implemented | ||
|
|
||
| func (m *keyManager) recoveryFromPrivateKey(privateKey string) error { | ||
| // TODO NewKeyStoreKeyManager to be implemented |
There was a problem hiding this comment.
Can we put the comment somewhere else? It is not for the following function, i think.
There was a problem hiding this comment.
Sure. I moved it above the NewPrivateKeyManager.
unclezoro
approved these changes
Apr 6, 2023
fynnss
changed the title
|
@yutianwu @forcodedancing would you do second review? |
alexgao001
force-pushed
the
refactor_sdk
branch
from
40326a8 to
3078217
Compare
yutianwu
approved these changes
Apr 17, 2023
randyahx
pushed a commit
that referenced
this pull request
Apr 20, 2023
unclezoro
pushed a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor key manager to hide private key.
Rationale
Enhance security
Example
NA
Changes
Notable changes: