-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get price boundary logic, remove useless query, enhance ci #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
changed the title
fix: get price boundary logic, remove useless AutoSettleRecord query
fix: get price boundary logic, remove useless query, enhance ci
Mar 29, 2023
fynnss
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adjust the method of searching prices based on timestamp from [) to (] to address boundary issues.
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the boundary logic for getting the price is SP.
Rationale
Previously
GetPriceByTime
in SP module will return the latest price less than or equal to the given time.It may cause a problem that the prices returned are different for a specific time.
Example
There are transactions in one block:
let p1 = get_price(now)
set_price(now, p2)
get_price(now)
will return p2, which may be different with p1We change the boundary logic to make it return the latest price less than(other than less than or equal to) the given time. Thus
get_price(now)
in step 3 will return p1. And for a specific parametert
inget_price
, the result will always be the same.Changes
Notable changes: