Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update-object-info for updateobject's visibility #138

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Mar 27, 2023

Description

add a new command (UpdateObjectInfo) for user to update ObjectInfo, currently only support modify visibility.

Rationale

ObjectInfo's properties can be modified.

Example

update-object-info [bucket-name] [object-name] [visibility]

Changes

Notable changes:

  • add a new command for storage/cli
  • ...

@jingjunLi jingjunLi added the wip label Mar 27, 2023
e2e/tests/storage_test.go Outdated Show resolved Hide resolved
proto/greenfield/permission/common.proto Outdated Show resolved Hide resolved
@jingjunLi jingjunLi force-pushed the chris/add-updateobjectinfo-cmd branch from 8240f53 to e07bfbe Compare April 12, 2023 12:31
@jingjunLi jingjunLi added r4r and removed wip labels Apr 12, 2023
@fynnss
Copy link
Contributor

fynnss commented Apr 14, 2023

@krish-nr pls notice that we add a new event here.

@jingjunLi jingjunLi force-pushed the chris/add-updateobjectinfo-cmd branch from 9f2207c to fe8d3a2 Compare April 14, 2023 03:07
@fynnss
Copy link
Contributor

fynnss commented Apr 14, 2023

Please use make proto-swagger-gen to update swagger file

fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator
@jingjunLi jingjunLi force-pushed the chris/add-updateobjectinfo-cmd branch from d8043e9 to 7f32253 Compare April 14, 2023 10:58
@jingjunLi
Copy link
Contributor Author

@fynnss I have fixed the conflict and updated the swagger file.

Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proto/greenfield/storage/events.proto Outdated Show resolved Hide resolved
@jingjunLi jingjunLi merged commit efc0f22 into develop Apr 18, 2023
randyahx pushed a commit that referenced this pull request Apr 20, 2023
* add update-object-info for updateobject's visibility
fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator

* add pb

* run make proto-swagger-gen
unclezoro pushed a commit that referenced this pull request Apr 20, 2023
* add update-object-info for updateobject's visibility
fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator

* add pb

* run make proto-swagger-gen
jingjunLi added a commit that referenced this pull request Apr 24, 2023
* add update-object-info for updateobject's visibility
fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator

* add pb

* run make proto-swagger-gen
jingjunLi added a commit that referenced this pull request Apr 25, 2023
* add update-object-info for updateobject's visibility
fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator

* add pb

* run make proto-swagger-gen
jingjunLi added a commit that referenced this pull request Apr 25, 2023
* add update-object-info for updateobject's visibility
fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator

* add pb

* run make proto-swagger-gen
jingjunLi added a commit that referenced this pull request Apr 26, 2023
* add update-object-info for updateobject's visibility
fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator

* add pb

* run make proto-swagger-gen
yutianwu pushed a commit that referenced this pull request Apr 26, 2023
#138) (#215)

* feat: add update-object-info for updateobject's visibility (#138)

* add update-object-info for updateobject's visibility
fix ACTION_UPDATE_OBJECT_INFO
add e2e test
fix protobuf check
fix updateobjectinfo bug
modify operator_address to operator

* add pb

* run make proto-swagger-gen

* fix conflict *pb.go
@unclezoro unclezoro deleted the chris/add-updateobjectinfo-cmd branch August 16, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants