bugfix: modify visibility's default to inherit & add VISIBILITY_TYPE_UNSPECIFIED enumeration type #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingjunLi
changed the title
|
LGTM. Plz fix the conflict and PR description. |
jingjunLi
force-pushed
the
chris/fix-visibility-default
branch
from
9602bba
to
4381150
Compare
unclezoro
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modify VisibilityType's default to VISIBILITY_TYPE_INHERIT. Add VISIBILITY_TYPE_UNSPECIFIED as protobuf guides
Rationale
User is not allowed to specify VISIBILITY_TYPE_UNSPECIFIED，Default is VISIBILITY_TYPE_INHERIT
Example
add an example CLI or API response...
Changes
Notable changes: