chore: refine bridge module #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
force-pushed
the
quality/bridge
branch
from
d3a2eb1 to
a04a9f8
Compare
owen-reorg
commented
Mar 22, 2023
owen-reorg
commented
Mar 22, 2023
owen-reorg
commented
Mar 22, 2023
owen-reorg
commented
Mar 22, 2023
owen-reorg
commented
Mar 22, 2023
|
Some TODOs are not resolved yet, please check again. |
owen-reorg
commented
Mar 23, 2023
yutianwu
force-pushed
the
quality/bridge
branch
from
e480205 to
a5f905e
Compare
|
LGTM. |
unclezoro
approved these changes
Mar 23, 2023
|
LGTM |
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr refines the codes of the bridge module according to the guideline.
Rationale
Refine the bridge module
Example
N/A
Changes
Notable changes: