Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine permission module for code quality #122

Merged
merged 13 commits into from
Mar 22, 2023
Merged

chore: refine permission module for code quality #122

merged 13 commits into from
Mar 22, 2023

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Mar 20, 2023 •
edited
Loading

Description

refine permission module for code quality by self-review

Rationale

Optimize code readability and add more comments

Example

NA

Changes

Notable changes:

  • refine the storage format for group member
  • remove useless code

@fynnss fynnss changed the base branch from master to develop March 20, 2023 02:12
@fynnss fynnss changed the title chros: refine permission module for code quality by self-review chore: refine permission module for code quality by self-review Mar 20, 2023
@forcodedancing forcodedancing requested a review from j75689 March 20, 2023 02:28
@j75689
Copy link
Contributor

j75689 commented Mar 20, 2023

Are there any unit tests that will cover the permission cases?

@fynnss
Copy link
Contributor Author

fynnss commented Mar 20, 2023

Are there any unit tests that will cover the permission cases?

Yes, you can view this PR, #110

And more unit test is coming later.

@fynnss fynnss added the wip label Mar 20, 2023
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from 91ac889 to 071aaf9 Compare March 20, 2023 08:07
@fynnss fynnss requested a review from flywukong March 20, 2023 08:07
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from 071aaf9 to cee126f Compare March 21, 2023 01:26
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch 2 times, most recently from 44abc5e to e15f872 Compare March 21, 2023 02:08
@fynnss fynnss mentioned this pull request Mar 21, 2023
Merged
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from e15f872 to 2068ed4 Compare March 21, 2023 02:18
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from 2068ed4 to 13e8fbb Compare March 21, 2023 02:22
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from 09dc198 to 7059b80 Compare March 21, 2023 03:02
@fynnss fynnss changed the title chore: refine permission module for code quality by self-review chore: refine permission module for code quality Mar 21, 2023
@fynnss fynnss added r4r and removed wip labels Mar 21, 2023
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from 7059b80 to 47e0133 Compare March 21, 2023 03:09
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from 47e0133 to b74f8fc Compare March 21, 2023 03:45
@fynnss @owen-reorg
Update proto/greenfield/storage/query.proto
c9d65fe 
Co-authored-by: Owen <owen.h@nodereal.io>
@fynnss fynnss requested a review from owen-reorg March 21, 2023 03:51
@fynnss fynnss requested a review from YukiAbyss March 21, 2023 05:55
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from a3aca9d to 379a546 Compare March 21, 2023 07:30
@fynnss fynnss force-pushed the fynn/refine_the_code_of_permission_module branch from 379a546 to 8a87050 Compare March 21, 2023 07:59
@fynnss fynnss requested review from RenRick and owen-reorg March 22, 2023 02:16
@fynnss fynnss merged commit ee7e8c7 into develop Mar 22, 2023
This was referenced Mar 24, 2023
Merged
Merged
@unclezoro unclezoro deleted the fynn/refine_the_code_of_permission_module branch April 18, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j75689 j75689 Awaiting requested review from j75689

@flywukong flywukong Awaiting requested review from flywukong

@unclezoro unclezoro Awaiting requested review from unclezoro

@YukiAbyss YukiAbyss Awaiting requested review from YukiAbyss

@RenRick RenRick Awaiting requested review from RenRick

@owen-reorg owen-reorg Awaiting requested review from owen-reorg

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fynnss @j75689 @RenRick @owen-reorg