Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine storage module #108

Merged
merged 2 commits into from
Mar 23, 2023
Merged

chore: refine storage module #108

merged 2 commits into from
Mar 23, 2023

Conversation

owen-reorg
Copy link
Contributor

@owen-reorg owen-reorg commented Mar 15, 2023 •
edited by fynnss
Loading

Description

refine the code of storage module

Rationale

To fix issues and improve code quality.

Example

NA

Changes

Notable changes:

  • rename BucketInfo.ReadQuota to ChargedReadQuota for better readability.
  • refine the readQuota in UpdateBucketInfo from uint64 to Uint64Value(pointer) for better readability

@owen-reorg owen-reorg requested a review from fynnss March 15, 2023 02:01
@owen-reorg owen-reorg changed the title chore: refine storage module [draft] chore: refine storage module Mar 15, 2023
@unclezoro unclezoro marked this pull request as draft March 16, 2023 07:21
@fynnss fynnss force-pushed the quality/storage branch 9 times, most recently from fa5f52b to 58a619d Compare March 17, 2023 08:27
fynnss
fynnss reviewed Mar 17, 2023
View reviewed changes
@fynnss fynnss mentioned this pull request Mar 17, 2023
Merged
@fynnss fynnss force-pushed the quality/storage branch 3 times, most recently from 2c2a96c to 981f618 Compare March 22, 2023 06:53
@fynnss fynnss marked this pull request as ready for review March 22, 2023 06:56
@fynnss fynnss changed the title [draft] chore: refine storage module chore: refine storage module Mar 22, 2023
@fynnss fynnss self-requested a review March 22, 2023 07:30
@fynnss fynnss added the r4r label Mar 22, 2023
fynnss
fynnss approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fynnss fynnss force-pushed the quality/storage branch 2 times, most recently from 06c7a05 to 811129a Compare March 23, 2023 00:54
@fynnss fynnss self-requested a review March 23, 2023 01:47
@fynnss fynnss force-pushed the quality/storage branch 2 times, most recently from 42e1041 to 187a47e Compare March 23, 2023 07:47
@owen-reorg @fynnss
* chore: refine storage module
452b494 
* refine the updateBucketInfo message
* rename read_quota to charged_read_quota
* rename all readquota to chargedreadquota
@owen-reorg
Copy link
Contributor Author

LGTM

@fynnss fynnss merged commit d7237bf into develop Mar 23, 2023
This was referenced Mar 24, 2023
Merged
Merged
@unclezoro unclezoro deleted the quality/storage branch April 18, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fynnss fynnss fynnss approved these changes

@yutianwu yutianwu yutianwu approved these changes

@pythonberg1997 pythonberg1997 pythonberg1997 approved these changes

@unclezoro unclezoro Awaiting requested review from unclezoro

@flywukong flywukong Awaiting requested review from flywukong

@joeylichang joeylichang Awaiting requested review from joeylichang

@RenRick RenRick Awaiting requested review from RenRick

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owen-reorg @yutianwu @fynnss @pythonberg1997