Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enhancement storage module #102

Merged
merged 3 commits into from
Mar 14, 2023
Merged

feat: Enhancement storage module #102

merged 3 commits into from
Mar 14, 2023

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Mar 13, 2023 •
edited
Loading

Description

Enhancement storage module

Rationale

NA

Example

NA

Changes

  • code-style
  • Empty all the TODO that leaves before
  • Refector and satisfy code standard
  • Improvement the code quality
  • Complete the unit test and e2e test

@fynnss fynnss added the wip label Mar 13, 2023
@fynnss fynnss marked this pull request as draft March 13, 2023 09:53
@fynnss fynnss force-pushed the enhancement_storage_module branch 2 times, most recently from 1851112 to 8b4034c Compare March 13, 2023 12:59
@fynnss fynnss force-pushed the enhancement_storage_module branch from 8b4034c to 90f6afb Compare March 13, 2023 13:44
@fynnss fynnss force-pushed the enhancement_storage_module branch from 0fd2fc8 to bc99661 Compare March 14, 2023 05:37
@fynnss fynnss marked this pull request as ready for review March 14, 2023 07:47
@fynnss fynnss removed the wip label Mar 14, 2023
@fynnss fynnss requested a review from flywukong March 14, 2023 08:16
@keefel
Copy link
Contributor

keefel commented Mar 14, 2023

Please fulfill the content in the PR template, with no deletion for the Rational and Examples part.

flywukong
flywukong approved these changes Mar 14, 2023
View reviewed changes
Copy link

@flywukong flywukong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fynnss fynnss merged commit 8b9d8a8 into develop Mar 14, 2023
@fynnss
Copy link
Contributor Author

fynnss commented Mar 14, 2023

Please fulfill the content in the PR template, with no deletion for the Rational and Examples part.

done

This was referenced Mar 14, 2023
Merged
Merged
@unclezoro unclezoro deleted the enhancement_storage_module branch April 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flywukong flywukong flywukong approved these changes

@yutianwu yutianwu yutianwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fynnss @keefel @yutianwu @flywukong