perf: receive done #1428
Merged
perf: receive done #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgao001
approved these changes
Jun 19, 2024
ruojunm
reviewed
Jun 19, 2024
modular/receiver/receive_task.go
Outdated
| log.CtxErrorw(ctx, "replicate piece unfinished", "task", task) | ||
| err = ErrUnfinishedTask | ||
| return nil, ErrUnfinishedTask | ||
| // If it already have data, skip this check |
There was a problem hiding this comment.
can you refine the comment?
ruojunm
reviewed
Jun 19, 2024
| @@ -114,10 +114,18 @@ func (r *ReceiveModular) HandleDoneReceivePieceTask(ctx context.Context, task ta | |||
| log.CtxErrorw(ctx, "failed to get checksum from db", "task", task, "error", err) | |||
| return nil, ErrGfSpDBWithDetail("failed to get checksum from db, error: " + err.Error()) | |||
| } | |||
| skipInsertIntegrityMeta := false | |||
There was a problem hiding this comment.
please add comment on this newly introduced field
ruojunm
reviewed
Jun 19, 2024
modular/receiver/receive_task.go
Outdated
| @@ -137,7 +145,7 @@ func (r *ReceiveModular) HandleDoneReceivePieceTask(ctx context.Context, task ta | |||
| } | |||
|
|
|||
| setIntegrityTime := time.Now() | |||
| if task.GetObjectInfo().GetIsUpdating() { | |||
| if !skipInsertIntegrityMeta && task.GetObjectInfo().GetIsUpdating() { | |||
There was a problem hiding this comment.
Could you refine these conditions?
ruojunm
approved these changes
Jun 21, 2024
This was referenced Jul 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
receice interface idempotent processing