Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customize staking module for inscription #46

Merged
merged 22 commits into from
Dec 23, 2022
Merged

feat: customize staking module for inscription #46

merged 22 commits into from
Dec 23, 2022

Conversation

keefel
Copy link
Contributor

@keefel keefel commented Nov 23, 2022 •
edited by fynnss
Loading

Description

Customize staking module for BNB Inscription, delete useless APIs from the original module and add new APIs.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@keefel keefel changed the title staking: customization for bfs feat: customize staking module for bfs Nov 23, 2022
@unclezoro
Copy link
Collaborator

The PR template is not our type, can you please change it in another PR?

@unclezoro unclezoro marked this pull request as draft November 24, 2022 13:37
@keefel
Copy link
Contributor Author

keefel commented Nov 24, 2022 •
edited
Loading

The PR template is not our type, can you please change it in another PR?

Sure, I will submit another PR to change the template to ours.

@keefel keefel force-pushed the keefe/dev branch 2 times, most recently from a8d1140 to 0d22fb2 Compare December 3, 2022 06:32
@keefel keefel changed the title feat: customize staking module for bfs feat: customize staking module for BNB Inscription Dec 3, 2022
j75689
j75689 reviewed Dec 22, 2022
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
@unclezoro unclezoro marked this pull request as ready for review December 23, 2022 01:41
@unclezoro unclezoro merged commit 240adbc into develop Dec 23, 2022
@j75689 j75689 mentioned this pull request Dec 23, 2022
Merged
@unclezoro unclezoro mentioned this pull request Dec 26, 2022
Merged
@yutianwu yutianwu mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing left review comments

@j75689 j75689 j75689 left review comments

@yutianwu yutianwu yutianwu left review comments

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
C:CLI C:Simulations C:x/auth C:x/authz C:x/bank C:x/distribution C:x/genutil C:x/gov C:x/slashing C:x/staking Type: CI wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keefel @unclezoro @yutianwu @j75689 @forcodedancing @randyahx