feat: performance improvement #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure whether we need to introduce 3 new ABCI methods. |
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 15, 2023
unclezoro
reviewed
Jun 16, 2023
unclezoro
reviewed
Jun 16, 2023
unclezoro
reviewed
Jun 16, 2023
unclezoro
reviewed
Jun 16, 2023
unclezoro
reviewed
Jun 19, 2023
unclezoro
reviewed
Jun 19, 2023
unclezoro
approved these changes
Jun 19, 2023
pythonberg1997
force-pushed
the
prefetch
branch
3 times, most recently
from
dcfdf94 to
b7d17d4
Compare
pythonberg1997
changed the title
yutianwu
approved these changes
Jul 4, 2023
unclezoro
reviewed
Jul 4, 2023
unclezoro
reviewed
Jul 4, 2023
| @@ -132,7 +143,7 @@ func (memR *Reactor) GetChannels() []*p2p.ChannelDescriptor { | |||
| return []*p2p.ChannelDescriptor{ | |||
| { | |||
| ID: mempool.MempoolChannel, | |||
| Priority: 5, | |||
| Priority: 1, | |||
There was a problem hiding this comment.
Why change the priority here? There are other channels, e.g., syncing, p2p.
There was a problem hiding this comment.
When there're too many txs in mempool, it may affect the vote and proposal's transport. So we set mempool's priority to minimum.
state/execution.go
Outdated
| @@ -108,7 +114,7 @@ func (blockExec *BlockExecutor) CreateProposalBlock( | |||
| // Fetch a limited amount of valid txs | |||
| maxDataBytes := types.MaxDataBytes(maxBytes, evSize, state.Validators.Size()) | |||
|
|
|||
| txs := blockExec.mempool.ReapMaxBytesMaxGas(maxDataBytes, maxGas) | |||
| txs := blockExec.mempool.ReapMaxTxsMaxBytesMaxGas(2400, maxDataBytes, maxGas) | |||
There was a problem hiding this comment.
Change 2400 to a const.
state/execution.go
Outdated
| startTime := time.Now().UnixNano() | ||
| interruptCh := make(chan struct{}) | ||
| // do pre execute for cache | ||
| var wg sync.WaitGroup |
There was a problem hiding this comment.
Do we need a wait group here? It seems that one interruptCh is fine.
forcodedancing
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to improve the performance of greenfield.
Changes
Notable changes: