Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]change interface of get timelock #84

Merged
merged 2 commits into from
Aug 21, 2019
Merged

[R4R]change interface of get timelock #84

merged 2 commits into from
Aug 21, 2019

Conversation

unclezoro
Copy link
Contributor

@unclezoro unclezoro commented Aug 21, 2019 •
edited
Loading

change

GetTimelocks(address string) ([]types.TimeLockRecord, error)
GetTimelock(address string, recordID int64) (types.TimeLockRecord, error)

to

GetTimelocks(addr types.AccAddress) ([]types.TimeLockRecord, error)
GetTimelock(addr types.AccAddress, recordID int64) (types.TimeLockRecord, error)

why:

  1. The style keeps consistent with previous.
  2. Rpc intends to use types.AccAddress object rather than string.

@unclezoro unclezoro merged commit 83eefca into master Aug 21, 2019
@unclezoro unclezoro deleted the timelock1 branch April 20, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackratos ackratos ackratos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unclezoro @ackratos