Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]les: fix GetProofsV2 bug (#21896) #54

Merged
merged 1 commit into from
Jan 8, 2021
Merged

[R4R]les: fix GetProofsV2 bug (#21896) #54

merged 1 commit into from
Jan 8, 2021

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Dec 15, 2020

Description

This PR fixes a bug in GetProofsV2 request serving that could potentially cause a panic because of header being nil.

Rationale

A DoS vulnerability can make a LES server crash via malicious GetProofsV2 request from a connected LES client.

Example

Mirror PR: ethereum/go-ethereum#21896
advisories: GHSA-r33q-22hv-j29q

Changes

This vulnerability only concerns users explicitly enabling les server; disabling les prevents the exploit.

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@unclezoro unclezoro changed the title les: fix GetProofsV2 bug (#21896) [R4R]les: fix GetProofsV2 bug (#21896) Dec 15, 2020
@unclezoro unclezoro merged commit 894b1e3 into master Jan 8, 2021
@unclezoro unclezoro deleted the fixLess branch January 18, 2021 12:26
@unclezoro unclezoro mentioned this pull request Jan 19, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants