Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: downgrade bls-eth-go-binary to make it same as the prysm-v5.0.0 #2907

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

zzzckck
Copy link
Collaborator

@zzzckck zzzckck commented Feb 22, 2025

Description

To fix the windows binary panic issue, check: #2903

Meanwhile, it also updates some other dependencies:

  • a.github.com/herumi/bls-eth-go-binary v1.31.0 -> v0.0.0-20210917013441-d37c07cfda4e
    make it same as prysm-v5.0.3
  • b.github.com/wealdtech/go-eth2-types: v2.8.2 -> v2.5.2
    make it same as prysm-v5.0.3
  • c.github.com/ferranbt/fastssz: v0.1.3 -> v0.0.0-20210120143747-11b9eff30ea9
    make it same as prysm-v5.0.3

Rationale

NA

Example

NA

Changes

NA

@zzzckck zzzckck marked this pull request as draft February 22, 2025 13:14
@zzzckck zzzckck mentioned this pull request Feb 22, 2025
@zzzckck zzzckck changed the base branch from master to develop February 24, 2025 01:55
@zzzckck zzzckck changed the title Win bls eth go.mod: upgrade bls-eth-go-binary to v1.32.1 Feb 24, 2025
@zzzckck zzzckck marked this pull request as ready for review February 24, 2025 01:58
buddh0
buddh0 previously approved these changes Feb 24, 2025
@buddh0
Copy link
Collaborator

buddh0 commented Feb 24, 2025

in v.1.4.x, github.com/herumi/bls-eth-go-binary v0.0.0-20210130185500-57372fb27371 is used, no this problem
the issue happens in v1.31.0

zlacfzy
zlacfzy previously approved these changes Feb 24, 2025
prefer use the origin v1.31.0 + WindowsPatch against upgrade
to v1.32.1
@zzzckck zzzckck dismissed stale reviews from zlacfzy and buddh0 via 984516d February 24, 2025 03:32
@zzzckck zzzckck changed the title go.mod: upgrade bls-eth-go-binary to v1.32.1 go.mod: upgrade bls-eth-go-binary to v1.31.0 with windows patch Feb 24, 2025
zlacfzy
zlacfzy previously approved these changes Feb 24, 2025
buddh0
buddh0 previously approved these changes Feb 24, 2025
@zzzckck zzzckck dismissed stale reviews from buddh0 and zlacfzy via 79b4aad February 24, 2025 04:23
@zzzckck zzzckck changed the title go.mod: upgrade bls-eth-go-binary to v1.31.0 with windows patch go.mod: downgrade bls-eth-go-binary to make it same as the prysm-v5.0.0 Feb 24, 2025
@zzzckck

This comment was marked as outdated.

@zzzckck zzzckck merged commit 8111dd9 into bnb-chain:develop Feb 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants