-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: render system bytecode by go:embed #2201
chore: render system bytecode by go:embed #2201
Conversation
08a09f7
to
ae5d08b
Compare
could include this PR after #2200 |
ae5d08b
to
7e6ae62
Compare
The code was generated by this tool -> https://github.com/j75689/bsc-bytecode-extraction-tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the byte code of mainnet is ok.
Will run full sync for testnet/mainnet and approve this PR sync passed, could take 2 weeks.
just ensure that hash of all codes not change after this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait
Description
render system bytecode by
go:embed
no impact on the system.
Rationale
As the system is upgraded, more and more
upgrade.go
files are expanding, making it difficult to open and review the code.Use
go:embed
instead to render bytecode into the binary during compilation, which will reduce the difficulty of code maintenance in the future.Example
n/a
Changes
Notable changes: