Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/state: skip deleting storages for EmptyTrie #1911

Merged
merged 1 commit into from
Oct 10, 2023
Merged

core/state: skip deleting storages for EmptyTrie #1911

merged 1 commit into from
Oct 10, 2023

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Oct 9, 2023 •
edited
Loading

Description

core/state: skip deleting storages for EmptyTrie

Rationale

trie is EmptyTrie for fast node,
iterate it will cause panic

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 merged commit 17ffdf1 into bnb-chain:master Oct 10, 2023
5 checks passed
@NathanBSC NathanBSC deleted the skip_delete_storage_EmptyTrie branch October 11, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galaio galaio galaio approved these changes

@Mercybudda Mercybudda Mercybudda approved these changes

@brilliant-lx brilliant-lx brilliant-lx approved these changes

@calmbeing calmbeing calmbeing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NathanBSC @galaio @Mercybudda @brilliant-lx @calmbeing @buddh0