Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: prepare for release v1.2.6 #1697

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

brilliant-lx
Copy link
Collaborator

@brilliant-lx brilliant-lx commented Jun 14, 2023

Description

update: v1.2.6 is replaced by v1.2.7, since a desired change will be included in hertz hard fork.

The testnet is expected to have a scheduled hardfork upgrade named Hertz(London&Berlin) at block height 31,103,030. The current block generation speed forecasts this to occur around 29th Jun 2023.

The Hertz hardfork will port some of London&Berlin upgrades from Ethereum to BSC for compatiblity. But due to the difference between the 2 networks, there would inevitably has difference in implementation, especially the different in EIP-1559, the BaseFee will be zero on BSC, so this hard fork will not introduce new burn mechanism neither the concept of GasTip. In short words, it only provides the interface, but actually no change to the current BSC Gas mechanism.

Here is the list of Hertz upgrade:

The validators and full node operators on testnet should switch their software version to v1.2.6 before 29th Jun 2023.

Rationale

FEATURE

  • #1697 upgrade: block height of Hertz(London&Berlin) on testnet
  • #1686 eip3529tests: refactor tests
  • #1676 EIP-3529 (BEP-212) Unit tests for Parlia Config
  • #1660 feat: add a tool for submitting evidence of maliciousvoting
  • #1623 P2P: try to limit the connection number per IP address
  • #1608 feature: Enable Berlin EIPs
  • #1597 feature: add malicious vote monitor
  • #1422 core: port several London EIPs on BSC

IMPROVEMENT

  • #1662 consensus, core/rawdb, miner: downgrade logs
  • #1654 config: use default fork config if not specified in config.toml
  • #1642 readme: update the disk requirement to 2.5TB
  • #1621 upgrade: avoid to modify RialtoGenesisHash when testing in rialtoNet

BUGFIX

  • #1682 fix: set the signer of parlia to the most permissive one
  • #1681 fix: not double GasLimit of block upon London upgrade
  • #1679 fix: check integer overflow when decode crosschain payload
  • #1671 fix: voting can only be enabled when mining
  • #1663 fix: ungraceful shutdown caused by malicious Vote Monitor
  • #1651 fix: remove naturally finality
  • #1641 fix: support getFilterChanges after NewFinalizedHeaderFilter

Example

None

@brilliant-lx brilliant-lx marked this pull request as draft June 14, 2023 09:49
@brilliant-lx brilliant-lx changed the title Prepare v1.2.6 WIP: Prepare v1.2.6 Jun 14, 2023
@brilliant-lx brilliant-lx force-pushed the preare_v1.2.6 branch 2 times, most recently from 1fac675 to 527d1de Compare June 15, 2023 09:43
@brilliant-lx brilliant-lx changed the title WIP: Prepare v1.2.6 release: prepare for release v1.2.6 Jun 15, 2023
@brilliant-lx brilliant-lx marked this pull request as ready for review June 15, 2023 10:05
}

func TestSstoreGasPreEIP3529(t *testing.T) {
func TestSstoreModifyGasPreLondon(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is already on develop. I don't understand why Github is showing this as new addition.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, you are right, I updated my branch. now it is ok.

@Johnmiller111
Copy link

If I keep that, I'm sure it will figure it out. John Miller

Copy link

@Johnmiller111 Johnmiller111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I can never figure it out, I will have just seen it in my email address John's last 185@gmail.com

@brilliant-lx brilliant-lx deleted the preare_v1.2.6 branch August 2, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants