Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To remove the diffsync protocol #1485

Closed
brilliant-lx opened this issue Apr 19, 2023 · 0 comments
Closed

To remove the diffsync protocol #1485

brilliant-lx opened this issue Apr 19, 2023 · 0 comments

Comments

@brilliant-lx
Copy link
Collaborator

brilliant-lx commented Apr 19, 2023 •
edited
Loading

Rationale

It is not a bug, neither a feature, but just to remove the diffsync protocol, which has been deprecated since v1.1.20
Although it is deprecated, i.e. the --diffsync flag no longer work, the diffsync protocol was still registered.
It could have cpu resource cost, since the node would create routine for it.
So we should not register the diff protocol to save the CPU resource.

Implementation

NA
@brilliant-lx brilliant-lx mentioned this issue Apr 19, 2023
Merged
@0xcb9ff9 0xcb9ff9 mentioned this issue Oct 30, 2023
Merged
github-merge-queue bot pushed a commit to dogechain-lab/dbsc that referenced this issue Oct 31, 2023
@0xcb9ff9
eth: default disable diff protocol (#45)
892275b 
### Description

disable `diff` protocol by default, `diff` protocol is deprecated,will
be deleted in the future

bnb-chain#1485
bnb-chain#1486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brilliant-lx