Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update eslint-plugin-jest to 27.9.0 #531

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

MikeMcC399
Copy link
Contributor

Issue

eslint-plugin-jest is configured in package.json with version ^27.0.4 and locked to eslint-plugin-jest@27.2.1, released Jan 2023, in package-lock.json.

A minimum version of eslint-plugin-jest@27.9.0 is required to support flat config files.

Change

Update eslint-plugin-jest to eslint-plugin-jest@27.9.0 (latest 27.x version)

Note: eslint-plugin-jest@28.0.0 or above cannot yet be used, since it drops support for @typescript-eslint/eslint-plugin v5.

Verification

On Ubuntu 24.04.1 LTS, Node.js 18.20.4

git clean -xfd
npm ci
npm run lint
npm test

Ignore warnings from npm ci:

npm warn deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.

Confirm no errors and no uncommitted changes.

@ddzz
Copy link
Collaborator

ddzz commented Oct 21, 2024

I'm pretty sure CI for Windows with Node 14.x has been failing for a long time and can be ignored.

@ddzz ddzz self-requested a review October 21, 2024 14:21
@MikeMcC399
Copy link
Contributor Author

@ddzz

I'm pretty sure CI for Windows with Node 14.x has been failing for a long time and can be ignored.

Thanks for your comment! I was a little misled because CI managed to pass all tests in the previous PR #530, however that was probably just luck.

I've bumped the Jest timeout for only Node.js 14 to 10 seconds (instead of the default 5 seconds). Node.js 14 already had some special settings for Jest.

Ultimately Node.js 14 will need to be dropped, however I'm trying to make the changes step-by-step, so I'd plan to remove Node.js 14 and 16 sometime later. They are both in end-of-life as far as Node.js is concerned, and ESLint v9 doesn't support these versions either.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 21, 2024 15:13
@ddzz ddzz merged commit 442afc4 into bmish:main Oct 21, 2024
6 checks passed
@MikeMcC399 MikeMcC399 deleted the update/eslint-plugin-jest branch October 21, 2024 16:59
@bmish bmish added the internal label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants