Remove special case handling for rule doc notice fixableAndHasSuggestions
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
remove-special-case-for-fixable-suggestions-notice
branch
from
6d99bb9 to
844b3a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid having "magic" notice types that toggle on/off by themselves. Instead, just have the
fixableAndHasSuggestionsrule doc notice type on by default, and it will adjust its own output depending on whether the rule is fixable or has suggestions. The separatefixableandhasSuggestionsnotice types are now off by default and only used when the user explicitly turns them on.No behavior change unless users were already customizing the behavior of these notices with
--rule-doc-notices.