Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASM_SOURCES not included in OBJECTS #150

Closed
Flo2410 opened this issue Mar 29, 2023 · 6 comments
Closed

ASM_SOURCES not included in OBJECTS #150

Flo2410 opened this issue Mar 29, 2023 · 6 comments

Comments

@Flo2410
Copy link

Flo2410 commented Mar 29, 2023

As mentioned by @has213, the ASM_SOURCES are no longer included in the OBJECTS after the last update with the fix for #143.

Adding OBJECTS += $(addprefix $(BUILD_DIR)/,$(notdir $(ASM_SOURCES:.s=.o))) fixed the issue.

Hi jortbmd,

Maybe there is an Error in the makefile generation

image
image

There are no UPPER_CASE_ASM_SOURCES and LOWER_CASE_ASM_SOURCES only ASM_SOURCES, which will not be included in OBJECTS

Originally posted by @has213 in #143 (comment)

@m4tto
Copy link

m4tto commented Mar 29, 2023

I have the same issue. The startup script is not compiled and the generated elf file is basically empty.

@jortbmd
Copy link
Member

jortbmd commented Mar 29, 2023

Thanks for opening up this issue! I am currently on it somehow this got through the whole pipeline without triggering errors. Just tested the fix and will try to resolve this ASAP. Will keep you posted

jortbmd added a commit that referenced this issue Mar 29, 2023
fix: issue #150 capitalized .S introduced a bug, this should fix this
@jortbmd
Copy link
Member

jortbmd commented Mar 29, 2023

Just published the new release. Could everybody please checks that this resolves the issue? Also thanks for notifying me this quickly!

@m4tto
Copy link

m4tto commented Mar 29, 2023

It's working now. Thanks!

@Flo2410
Copy link
Author

Flo2410 commented Mar 29, 2023

Yes, it works. Thanks!

FYI: The comment # list of ASM program objects is duplicated.

@jortbmd
Copy link
Member

jortbmd commented Mar 29, 2023

Great to hear that it is working. @Flo2410 Thanks for pointing out the double comment. For now I will fix this in an upcoming release.
As it is working now I will close this issue. Should any of you experience a new issue or wants a feature request don't hesitate to open up a new issue.

@jortbmd jortbmd closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants