-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows/MacOS to test-sundials CI #197
Conversation
Can you change this to use tox, so any changes that are needed to be made can be centralised in tox (and hence avoid coupling to the specific CI system)? |
I changed the new CI job to use This seems to be an issue with how the runner sets up its virtual environments with After this PR is closed, can you also do a v3.1.1 release that includes the fix from PR #196? Even though the PR was closed, there was no release to push the patch to PyPI. |
@aragilar, I was able to fix the SSL issue for the Windows/py39 combination by using a different action to setup the You should now be able to review and close this PR when you have time. Also, just to make sure it doesn't fall off your radar, could you please do a v3.1.1 release after closing so the patch from PR #196 is available on PyPI? Thanks! |
Cool, thanks for the changes! I think at some point we should work out how to build SUNDIALS properly on Windows/MacOS so we can test pre-release versions of SUNDIALS (so we can be more proactive about adapting to change/passing on feedback about changes), but I think if conda-forge is keeping relatively up to date with SUNDAILS, then using conda makes sense for now. |
3.1.1 should appear on PyPI once the CI finished processing the tag. |
This PR adds a build-and-test routine to
test-sundials.yml
for both Windows and MacOS to improve catching breaking changes on various operating systems, as suggested in PR #196.Notes:
conda-forge
(double precision, 32-bit index).macos-13
to thematrix.os
section.macos-latest
uses arm64 architectures andmacos-13
uses x86_64, so testing both would likely be more robust.matrix.python-version
section since those are the oldest and newest versions that are currently supported. Feel free to add more.Comments:
I noticed that the tests inside
packages/scikits-odes-sundials/src/scikits_odes_sundials
only test the_get_num_args
function, so the tests here are not particularly robust. Now thatscikits-odes-sundials
can be distributed as its own package, it may be worth moving over some of the more rigorous tests that are specific toodes-sundials
frompackages/scikits-odes/src/scikits/odes/tests
.